Update AndroidManifest.xml #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main objective here is to remove the allowBackup and supportsRtl tags; they were causing manifest merge errors. But the most correct fix is to remove the application tag completely. Libraries don't need it.
natario1
approved these changes
Aug 30, 2018
|
Thanks ! |
markusressel
pushed a commit
that referenced
this pull request
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective here is to remove the allowBackup and supportsRtl tags; they were causing manifest merge errors.
But the most correct fix is to remove the application tag completely. Libraries don't need it.