Fix #41, Do not use aux_source_directory in sample build script #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use "aux_source_directory" in the build script, but rather list out each file explicitly. In particular this avoids incorrectly including the sample_table.c file in the app build.
4722f8f to
f49c17a
Compare
|
NOTE: rebased this changeset to latest master. This is ready for CCB review. |
|
CCB 20200318 - Approved |
astrogeco
approved these changes
Mar 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #41
Do not use
aux_source_directoryin the build script, but rather list out each file explicitly. In particular this avoids incorrectly including thesample_table.cfile in the app build.Testing performed
Build software with
SIMULATION=native ENABLE_UNIT_TESTS=TRUEand confirm thatsample_table.cis no longer included within the link ofsample_app.so.Execute CFE and confirm basic normal operation
Expected behavior changes
No impact to behavior
System(s) tested on
Ubuntu 18.04 LTS 64-bit
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.