Skip to content

Sample App has error counter and command counter reversed #25

@jphickey

Description

@jphickey

Describe the bug
The SAMPLE_ReportHousekeeping function reports the error count and command count values reversed.

To Reproduce
Send a NOOP command, then report housekeeping, and see that the error count is in place of the the command count.

Expected behavior
The error count and command count should not be reversed.

Code snips

Inside SAMPLE_ReportHousekeeping(), it has:

    Sample_AppData.SAMPLE_HkTelemetryPkt.sample_command_error_count = Sample_AppData.CmdCounter;
    Sample_AppData.SAMPLE_HkTelemetryPkt.sample_command_count = Sample_AppData.ErrCounter;

System observed on:
Ubuntu 18.04 LTS 64-bit

Additional context
Actually discovered this when writing the unit test for the ReportHousekeeping function (#8), and the test case failed because the counters were backwards.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions