CFE_SB_ValidateChecksum implementation does not match description

**Describe the bug**
CFE_SB_ValidateChecksum claims it returns true if not supported:

https://github.com/nasa/cFE/blob/d217ca39f1de74695f0d4e0eb427f90fbe8b1156/fsw/cfe-core/src/inc/cfe_sb.h#L1314-L1316

but also claims it returns false:

https://github.com/nasa/cFE/blob/d217ca39f1de74695f0d4e0eb427f90fbe8b1156/fsw/cfe-core/src/inc/cfe_sb.h#L1321-L1323

and then implements a false return:

https://github.com/nasa/cFE/blob/d217ca39f1de74695f0d4e0eb427f90fbe8b1156/fsw/cfe-core/src/sb/cfe_sb_util.c#L398-L401

**To Reproduce**
Read the code.

**Expected behavior**
Consistency

**Code snips**
See above

**System observed on:**
N/A

**Additional context**
None

**Reporter Info**
Jacob Hageman - NASA/GSFC

	/* if msg type is telemetry or there is no secondary hdr... */
	if((CCSDS_RD_TYPE(MsgPtr->Hdr) == CCSDS_TLM)\|\|(CCSDS_RD_SHDR(MsgPtr->Hdr) == 0)){
	return false;
	}/* end if */

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

CFE_SB_ValidateChecksum implementation does not match description #733

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	** \par Assumptions, External Events, and Notes:
	** - If the underlying implementation of software bus messages does not
	** include a checksum field, then this routine will always return \c true.

	** \return Boolean checksum result
	** \retval true The checksum field in the packet is valid.
	** \retval false The checksum field in the packet is not valid or the message type is wrong.

CFE_SB_ValidateChecksum implementation does not match description #733

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions