Give more specific errors in name_show #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More detail is always good UX-wise. Doesn't change the error code, so this isn't an API-breaking change.
|
@domob1812 This is ready for review. |
|
ACK 8dbcb34. |
|
This broke some of the regtests. I will fix them as part of the upstream merges. |
domob1812
added a commit
to domob1812/namecoin-core
that referenced
this pull request
Sep 7, 2021
Adjustments to the wallet code with name changes (like GetNameCredit/Debit, or CreateTransaction with input) made necessary with the upstream change bitcoin/bitcoin#22100. Fixed some of the regtests that were broken by namecoin#453.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More detail is always good UX-wise. Doesn't change the error code, so this isn't an API-breaking change.