Feature/multi lang template #382
Conversation
… would not work without reflected changes in package-lock file.
Previously it has not been stopped correctly because docker image with the demo apps ignores SIGTERM cmd.
| export async function up(knex: Knex): Promise<void> { | ||
| return knex.schema.createTable(tables.templatesLocalized, table => { | ||
| table.string('templateName', 50).notNullable().references('templates.name').onDelete('CASCADE'); | ||
| table.text('content').notNullable(); |
There was a problem hiding this comment.
table.text('content', 'mediumtext').notNullable();
There was a problem hiding this comment.
what means 'mediumtext'?
There was a problem hiding this comment.
found answer here knex/knex#1064 (comment)
Updated type
…t allows only 64kb of content.
| @@ -0,0 +1,4 @@ | |||
| export const tables = { | |||
There was a problem hiding this comment.
the purpose of this file is enumeration of existing tables ?
There was a problem hiding this comment.
yeap, in order not to write string literal every time when table name is needed
| export interface LocalizedTemplate { | ||
| templateName: string; | ||
| content: string; | ||
| locale?: string; |
There was a problem hiding this comment.
if locale is absent I would expect default one.
how to configure default locale ?
There was a problem hiding this comment.
default locale is specified on content column of the template table
There was a problem hiding this comment.
But you are right it should be required
|
|
||
| const validateRequestBeforeCreateTemplate = validateRequestFactory([{ | ||
| schema: templateSchema, | ||
| selector: 'body', | ||
| }]); | ||
|
|
||
| const createTemplate = async (req: Request, res: Response): Promise<void> => { | ||
| const template = req.body; | ||
| const request = req.body; |
There was a problem hiding this comment.
template looked like more as an entity the request
| @@ -43,6 +43,7 @@ describe('ErrorHandler', () => { | |||
| }); | |||
|
|
|||
| const response = await server.get('/_ilc/500').expect(500); | |||
| console.log(response.text); | |||
There was a problem hiding this comment.
Is it expected to be here?
No description provided.