Skip to content

chore: added glob parameter for karma to watch specific file #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

chore: added glob parameter for karma to watch specific file #304

merged 1 commit into from
May 26, 2021

Conversation

this-self
Copy link
Contributor

No description provided.

@this-self this-self requested a review from nightnei May 25, 2021 15:40
@nightnei
Copy link
Contributor

nightnei commented May 26, 2021 •
edited
Loading

@ifree92 to solve this problem we can use .only or .skip, don't we?
or I missed something?
anyway, it's useful changes so approved it.

@this-self
Copy link
Contributor Author

this-self commented May 26, 2021 •
edited
Loading

@ifree92 to solve this problem we can use .only or .skip, don't we?
or I missed something?
anyway, it's useful changes so approved it.

Well noted. Let me check your suggestions before final merging.
Will revert on it soon

UPD: seems .only/.skip functionality is absent for karma so we have the only way. Merging PR for now.

@this-self this-self merged commit 8d7336d into master May 26, 2021
@this-self this-self deleted the addIlcClientKarmaGlobParameter branch May 26, 2021 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@StyleT StyleT StyleT approved these changes

@nightnei nightnei nightnei approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@this-self @nightnei @StyleT