chore: added tests for client WrapApp class #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleT
suggested changes
May 26, 2021
| import chai from 'chai'; | ||
| import sinon from 'sinon'; | ||
|
|
||
| describe('WrapApp', () => { |
There was a problem hiding this comment.
- You're missing test cases for unmount (when we have wrapper or app rendered).
- I would try to write utility function to check state of all callbacks at once. Ex.
expectBallbacksToBe(callbacks, 'mounted') - Separately we need to test the fact that App Wrapper always receives
getCurrentBasePath() = '/', unique appId and it's own props while wrapped app receives "own" props from registry. - We also need to check that class also works with callbacks provided as array of functions. See
#canonizeCallbacks
|
@StyleT I have made changes regarding your comments. Probably, would be good to group them either:
For now leaved as is. Other moment is about expectations check of arrayed callbacks arguments. I have hardcoded them manually to be able to track the error on exact line. If you prefer to have there an additional abstraction layer - I will do, let me know. |
StyleT
approved these changes
May 26, 2021
nightnei
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.