Feature/optional order pos in routes #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3db1b5 to
8c5c30e
Compare
8c5c30e to
f3459c0
Compare
nightnei
reviewed
May 6, 2021
| if (isMySQL(knex)) { | ||
| return knex.raw("ALTER TABLE routes ADD domainIdIdxble int(11) GENERATED ALWAYS AS (coalesce(domainId, -1)) STORED;"); | ||
| } else { | ||
| return knex.raw("ALTER TABLE routes ADD COLUMN domainIdIdxble INT GENERATED ALWAYS AS (coalesce(domainId, -1)) VIRTUAL;"); |
There was a problem hiding this comment.
do you use "VIRTUAL" since it's the only way to alter a table in sqlite?
nightnei
reviewed
May 6, 2021
| export async function up(knex: Knex): Promise<void> { | ||
| return knex.schema.alterTable('routes', table => { | ||
| table.dropUnique(['route', 'domainId'], 'routes_route_and_domainId_unique'); | ||
| table.unique(['route', 'domainIdIdxble'], 'routes_route_and_domainIdIdxble_unique'); |
There was a problem hiding this comment.
"Idxble" - what does it mean?
nightnei
reviewed
May 6, 2021
|
|
||
| export async function down(knex: Knex): Promise<void> { | ||
| if (!isMySQL(knex)) { | ||
| throw new Error('Not implemented'); |
There was a problem hiding this comment.
does it break the downing of migrations from this one?
nightnei
reviewed
May 6, 2021
| @@ -14,15 +14,19 @@ const testUser = Object.freeze({ | |||
| describe('Versioning Unit', () => { | |||
| let db: VersionedKnex; | |||
| let versionSevice: Versioning; | |||
| before(async () => { | |||
| before(async function() { | |||
| this.timeout(10 * 1000); | |||
There was a problem hiding this comment.
which changes caused setting this timeout?
There was a problem hiding this comment.
Once I had build failed because of the timeout error.
nightnei
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.