feat: support a few domains (500) #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed612be to
66b0652
Compare
|
Pls write E2E tests for this |
Base automatically changed from
feature/supportFewDomains_UI
to
feature/supportFewDomains_master
April 16, 2021 15:05
8fcaf18 to
b2ce5be
Compare
fixed |
done |
StyleT
approved these changes
Apr 19, 2021
| @@ -6,13 +6,14 @@ errors.WrapWithCacheError = extendError('WrapWithCacheError'); | |||
| const wrapWithCache = (localStorage, logger, createHash = hashFn) => (fn, cacheParams = {}) => { | |||
| const { | |||
| cacheForSeconds = 60, | |||
| name = '', // "hash" of returned value is based only on arguments, so with the help "name" we can add prefix to hash | |||
There was a problem hiding this comment.
I think this should be a required parameter.
| } = cacheParams; | ||
|
|
||
| const cacheResolutionPromise = {}; | ||
|
|
||
| return (...args) => { | ||
| const now = Math.floor(Date.now() / 1000); | ||
| const hash = args.length > 0 ? createHash(JSON.stringify(args)) : '__null__'; | ||
| const hash = `${name ? name + '__' : ''}${args.length > 0 ? createHash(JSON.stringify(args)) : '__null__'}`; |
There was a problem hiding this comment.
Pass name to hash function. Don't do a concatenation after
There was a problem hiding this comment.
So now we would use hash fn even if we don't have args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.