-
Notifications
You must be signed in to change notification settings - Fork 46
feat: global API for navigation added #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: use common unlocalizeUrl function feat: create guard for server feat: create guard for client side feat: build patch events feat: use navigation hook and init everything in client js feat: use common PluginManager on both client and server sides feat: provide an ability to add many navigation hooks fix: update PluginManager mock feat: cover guard manager with tests feat: run every hook and return result then fix: update a var name feat: export remove navigation hook function feat: cover setup events with tests fix: system limit for number of file watchers reached chore: rename test suites feat: cover plugin manager with tests feat: cover guard manager with tests
…rect to URL or when navigating from hook
63dfe35
to
fe514f3
Compare
# Conflicts: # ilc/client.js # ilc/server/pluginManager.js
379f25c
to
4ce7e91
Compare
nightnei
approved these changes
Feb 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.