Skip to content

feat: add meta field to route #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2021
Merged

feat: add meta field to route #237

merged 1 commit into from
Jan 8, 2021

Conversation

oleh-momot
Copy link
Contributor

No description provided.

StyleT
StyleT suggested changes Jan 4, 2021
View reviewed changes
registry/server/migrations/20201228201314_route_meta.ts Outdated


export async function up(knex: Knex): Promise<any> {
return knex.schema.createTable('route_meta', table => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating separate table - I would just add TEXT column to routes table.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@oleh-momot oleh-momot force-pushed the feature/registry-route-meta branch 3 times, most recently from 63a2df6 to d632a85 Compare January 6, 2021 09:59
@oleh-momot oleh-momot changed the base branch from feature/route-guards to master January 6, 2021 10:05
@oleh-momot oleh-momot force-pushed the feature/registry-route-meta branch 3 times, most recently from 435fb5b to 3320f2b Compare January 8, 2021 08:21
@oleh-momot oleh-momot force-pushed the feature/registry-route-meta branch from 3320f2b to c789a80 Compare January 8, 2021 08:45
@oleh-momot oleh-momot requested a review from StyleT January 8, 2021 08:52
@oleh-momot oleh-momot merged commit 05dd64a into master Jan 8, 2021
@oleh-momot oleh-momot deleted the feature/registry-route-meta branch January 8, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@StyleT StyleT StyleT approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleh-momot @StyleT