feat: provide an ability to ignore invalid SSL certificates while usi… #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StyleT
suggested changes
Dec 18, 2020
| const ssr = overrideConfig.apps[appName].ssr; | ||
|
|
||
| if (ssr !== undefined && ssr.src !== undefined && ssr.src.startsWith('https:')) { | ||
| overrideConfig.apps[appName].ssr.ignoreInvalidSsl = true; |
There was a problem hiding this comment.
Add comment which explains why we're doing this
There was a problem hiding this comment.
Provided a comment to explain it
| @@ -1,21 +1,25 @@ | |||
| import { expect } from 'chai'; | |||
| const parseOverrideConfig = require('./parse-override-config'); | |||
|
|
|||
| const assignIgnoreInvalidSsl = (ssr, protocol = 'http:') => protocol === 'https:' | |||
There was a problem hiding this comment.
Pls create separate test for this functionality.
StyleT
suggested changes
Dec 18, 2020
| @@ -444,7 +446,7 @@ describe('server router', () => { | |||
| })).toString('base64')); | |||
|
|
|||
| const expectedPage = | |||
| `<fragment id="${registryConfig.apps['apps'].name}" slot="apps" timeout="${registryConfig.apps.apps.ssr.timeout}" src="${expectedAppsUrl.toString()}" primary="true"></fragment>`; | |||
| `<fragment id="${registryConfig.apps['apps'].name}" slot="apps" timeout="${registryConfig.apps.apps.ssr.timeout}" src="${expectedAppsUrl.toString()}" ignore-invalid-ssl="false" primary="true"></fragment>`; | |||
There was a problem hiding this comment.
ignore-invalid-ssl="false" counts as true.
added 3 commits
December 21, 2020 11:42
8539bd4 to
a7ec4ea
Compare
…ave a src in SSR property
a7ec4ea to
175617f
Compare
StyleT
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng LDE