Feature/openid session impersonation #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleh-momot
suggested changes
Oct 29, 2020
registry/server/auth.ts
Outdated
| @@ -255,5 +260,9 @@ async function getEntityWithCreds(provider: string, identifier: string, secret: | |||
|
|
|||
| delete user.secret; | |||
There was a problem hiding this comment.
So, it does not need anymore if I got it correctly
registry/tests/auth.spec.ts
Outdated
| @@ -79,7 +81,7 @@ describe('Authentication / Authorization', () => { | |||
| }) | |||
| .expect(200) | |||
| .expect('set-cookie', /connect\.sid=.+; Path=\/; HttpOnly/) | |||
| .expect('set-cookie', /ilc:userInfo=%7B%22identifier%22%3A%22root%22%2C%22role%22%3A%22admin%22%7D; Path=\//); | |||
| .expect('set-cookie', /ilc:userInfo=%7B%22authEntityId%22%3A1%2C%22identifier%22%3A%22root%22%2C%22role%22%3A%22admin%22%7D; Path=\//); | |||
There was a problem hiding this comment.
Can we use URL encode and decode here and in other such places?
Because I guess, if something will be wrong it will take us an extra effort to understand exactly what it is wrong
nightnei
approved these changes
Oct 29, 2020
oleh-momot
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.