Skip to content

Add settings to config, process trailing slash on server and client s… #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 26, 2020
Merged

Add settings to config, process trailing slash on server and client s… #216

merged 13 commits into from
Oct 26, 2020

Conversation

oleh-momot
Copy link
Contributor

…ides

@oleh-momot oleh-momot requested review from StyleT and nightnei October 16, 2020 08:25
StyleT
StyleT suggested changes Oct 16, 2020
View reviewed changes
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch 3 times, most recently from 51ec87a to 29215ad Compare October 20, 2020 08:55
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch from 29215ad to e6bdba6 Compare October 20, 2020 08:55
@oleh-momot oleh-momot requested a review from StyleT October 20, 2020 09:13
StyleT
StyleT reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@StyleT StyleT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're missed to handle case when App uses pushHistory to change url

StyleT
StyleT suggested changes Oct 20, 2020
View reviewed changes
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch from 3f9450f to 9c4e1c3 Compare October 21, 2020 12:09
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch from 51ba555 to 2c92ed9 Compare October 21, 2020 12:11
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch from e044ab6 to c6fc815 Compare October 21, 2020 13:26
@oleh-momot oleh-momot requested a review from StyleT October 21, 2020 14:25
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch 3 times, most recently from 415a720 to f6cb4c6 Compare October 21, 2020 15:30
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch from f6cb4c6 to f0ff257 Compare October 21, 2020 15:37
oleh-momot
oleh-momot commented Oct 21, 2020
View reviewed changes
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch 2 times, most recently from a70f3b2 to 23da31d Compare October 22, 2020 14:04
@oleh-momot oleh-momot force-pushed the feature/trailing-slash branch from 23da31d to 29ebaca Compare October 22, 2020 14:34
StyleT
StyleT reviewed Oct 23, 2020
View reviewed changes
@oleh-momot oleh-momot requested a review from StyleT October 23, 2020 10:35
StyleT
StyleT suggested changes Oct 23, 2020
View reviewed changes
@oleh-momot oleh-momot requested a review from StyleT October 23, 2020 14:11
@nightnei
Copy link
Contributor

can we create one field (object) for auth.openId?
#216 (comment)

@oleh-momot
Copy link
Contributor Author

can we create one field (object) for auth.openId?
#216 (comment)

Discussed
It is an improvement that we are going to add to Backlog

redirectToBaseUrlWithTrailingSlash -> redirectToTrailingSlash & redir…
f62b195 
…ectToBaseUrl -> redirectToNonTrailingSlash
@oleh-momot oleh-momot merged commit 38a2ffe into master Oct 26, 2020
@oleh-momot oleh-momot deleted the feature/trailing-slash branch October 26, 2020 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@StyleT StyleT StyleT approved these changes

@nightnei nightnei nightnei approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleh-momot @nightnei @StyleT