Feature/i18n/basic ssr implementation #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleh-momot
reviewed
Sep 22, 2020
| const _ = require('lodash'); | ||
| const cookie = require('cookie'); | ||
|
|
||
| const DEFAULT_LOCALE = 'en-US'; |
There was a problem hiding this comment.
Perhaps, it would be nice to have this and the code below in the config
What do you think about it?
oleh-momot
reviewed
Sep 22, 2020
ilc/server/tailor/factory.js
Outdated
| const filterHeaders = require('./filter-headers'); | ||
| const errorHandlingService = require('../errorHandler/factory'); | ||
| const errorHandlerSetup = require('./error-handler'); | ||
| const fragmentHooks = require('./fragment-hooks'); | ||
| const ConfigsInjector = require('./configs-injector'); | ||
| const processFragmentResponse = require('./process-fragment-response'); | ||
|
|
||
| module.exports = function (cdnUrl, nrCustomClientJsWrapper = null) { | ||
| module.exports = function (cdnUrl, nrCustomClientJsWrapper = null, registryService) { |
There was a problem hiding this comment.
I guess registryService should be the first param because nrCustomClientJsWrapper is null by default
There was a problem hiding this comment.
moreover, imho it's better to use object(e.g {cdnUrl, nrCustomClientJsWrapper = null, registryService}) here, since we have too many params and some of them are optional
There was a problem hiding this comment.
Changed args order. We can use obj syntax later IMO
nightnei
approved these changes
Sep 22, 2020
oleh-momot
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.