Skip to content

fix: destroy spinner when exists contentful data #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2020
Merged

fix: destroy spinner when exists contentful data #194

merged 1 commit into from
Aug 20, 2020

Conversation

nightnei
Copy link
Contributor

transition to ms which render empty div immediately and contentful data are rendered asynchronously, so spinner is destroyed earlier then it's necessary

@nightnei nightnei requested review from StyleT and oleh-momot August 20, 2020 12:27
@nightnei nightnei changed the title fix: transition with async contentful data fix: destroy spinner when exists contentful data Aug 20, 2020
@nightnei nightnei merged commit 83e5d58 into master Aug 20, 2020
@nightnei nightnei deleted the fixTransitionToAsyncLoadedFragment branch August 20, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@StyleT StyleT StyleT approved these changes

@oleh-momot oleh-momot oleh-momot approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nightnei @StyleT @oleh-momot