Skip to content

fix(ilc/server): parse invalid urls like '///' #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(ilc/server): parse invalid urls like '///' #535

merged 1 commit into from
Oct 4, 2023

Conversation

stas-nc
Copy link
Member

@stas-nc stas-nc commented Oct 4, 2023

parsing done via parseurl library used in express for safety and performance +format fixes

@stas-nc
fix(ilc/server): parse invalid urls like '///'
239823a 
parsing done via parseurl library used in express for safety and performance
+format fixes
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Coverage Report

Ilc/server

Commit SHA:ae97d9aec63b155dce9123969f7baa82a92e4a73

Test coverage results 🧪

Code coverage diff between base branch:master and head branch: bugfix/triple-slash
File details
Status File % Stmts % Branch % Funcs % Lines
🔴 total 89.88 (-0.01) 85.07 (0) 86.44 (-0.05) 89.85 (0)
➖ /codebase/client.js 0 100 100 0
➖ /codebase/client.plugins.manifest.js 0 100 100 0
➖ /codebase/server.plugins.manifest.js 100 100 100 100
➖ /codebase/common/Environment.js 100 100 100 100
➖ /codebase/common/SdkOptions.js 66.66 50 100 66.66
➖ /codebase/common/UrlProcessor.js 100 100 100 100
➖ /codebase/common/constants.js 0 100 100 0
➖ /codebase/common/i18nCookie.js 90 85.71 100 90
➖ /codebase/common/localStorage.js 92.59 100 100 92.59
🔴 /codebase/common/utils.js 73.33 (-1.67) 50 (0) 77.77 (-2.23) 71.42 (-0.99)
➖ /codebase/common/wrapWithCache.js 100 90 100 100
➖ /codebase/common/Slot/Slot.js 83.33 100 75 83.33
➖ /codebase/common/Slot/SlotCollection.js 87.5 50 100 87.5
➖ /codebase/common/Slot/SpaSlot.js 0 100 0 0
➖ /codebase/common/Slot/SpaSlotCollection.js 0 0 0 0
➖ /codebase/common/Slot/test/fixture.js 100 100 100 100
➖ /codebase/common/guard/actionTypes.js 100 100 100 100
➖ /codebase/common/guard/errors.js 100 100 100 100
➖ /codebase/common/router/Router.js 98.27 93.54 100 98.27
➖ /codebase/common/router/errors.js 100 100 100 100
➖ /codebase/server/GuardManager.js 100 100 100 100
➖ /codebase/server/app.js 90.9 78.94 85.71 90.9
➖ /codebase/server/i18n.js 85.36 82.6 66.66 84.61
➖ /codebase/server/index.js 0 100 100 0
➖ /codebase/server/objectToBase64.js 100 100 100 100
➖ /codebase/server/ping.js 75 100 50 75
➖ /codebase/server/serveStatic.js 50 50 100 50
➖ /codebase/server/server.js 0 0 0 0
➖ /codebase/server/application/application.js 90 75 100 90
➖ /codebase/server/context/context.js 100 100 100 100
➖ /codebase/server/errorHandler/ErrorHandler.js 94.54 60 100 94.54
➖ /codebase/server/errorHandler/defaultErrorPage.js 100 100 100 100
➖ /codebase/server/errorHandler/factory.js 100 100 100 100
➖ /codebase/server/logger/accessLogger.js 88.23 63.63 100 88.23
➖ /codebase/server/logger/enhanceLogger.js 94.44 75 100 94.44
➖ /codebase/server/plugins/PluginsLoader.js 75 50 50 75
➖ /codebase/server/plugins/pluginManager.js 100 100 100 100
➖ /codebase/server/plugins/reportingPlugin.js 100 50 100 100
➖ /codebase/server/registry/Registry.js 97.05 82.75 100 97.03
➖ /codebase/server/registry/TemplateParser.js 100 100 100 100
➖ /codebase/server/registry/factory.js 100 100 100 100
➖ /codebase/server/registry/isTemplateValid.js 100 100 100 100
➖ /codebase/server/services/CanonicalTagService.js 100 50 100 100
➖ /codebase/server/services/CspBuilderService.js 100 92.3 100 100
➖ /codebase/server/services/HrefLangService.js 92.59 66.66 100 92.59
➖ /codebase/server/tailor/configs-injector.js 99.06 95.65 100 99.03
➖ /codebase/server/tailor/error-handler.js 85.71 83.33 100 85.71
➖ /codebase/server/tailor/errors.js 100 100 100 100
➖ /codebase/server/tailor/factory.js 94.44 0 66.66 94.44
➖ /codebase/server/tailor/fetch-template.js 100 83.33 100 100
➖ /codebase/server/tailor/filter-headers.js 100 87.5 100 100
➖ /codebase/server/tailor/fragment-hooks.js 94.11 96.15 100 94.11
➖ /codebase/server/tailor/merge-configs.js 100 95.45 100 100
➖ /codebase/server/tailor/parse-override-config.js 100 93.47 100 100
➖ /codebase/server/tailor/process-fragment-response.js 100 94.73 100 100
➖ /codebase/server/tailor/request-fragment.js 91.76 71.42 90 91.76
➖ /codebase/server/tailor/server-router.js 98.5 97.05 100 98.48
➖ /codebase/server/utils/utils.js 100 100 100 100
➖ /codebase/tests/helpers.js 75.86 100 78.57 76.92

Ilc/client

Commit SHA:ae97d9aec63b155dce9123969f7baa82a92e4a73

Test coverage results 🧪

Code coverage diff between base branch:master and head branch: bugfix/triple-slash
File details
Status File % Stmts % Branch % Funcs % Lines
🟢 total 91.42 (0.07) 80.52 (0) 87.45 (0.3) 91.59 (-0.01)
➖ /codebase/client/AsyncBootUp.js 100 75 100 100
➖ /codebase/client/BundleLoader.js 91.66 96.66 78.57 91.48
➖ /codebase/client/ClientRouter.js 95.7 89.01 95.65 95.51
➖ /codebase/client/CssTrackedApp.js 95 85 92.3 96.42
➖ /codebase/client/GuardManager.js 96.15 77.77 100 96.15
➖ /codebase/client/ParcelApi.js 97.05 87.5 100 96.96
➖ /codebase/client/WrapApp.js 97.18 76.47 93.75 98.52
➖ /codebase/client/composeAppSlotPairsToRegister.js 100 100 100 100
➖ /codebase/client/dispatchSynchronizedEvent.js 96.96 100 100 96.55
➖ /codebase/client/i18n.js 90.69 86.66 90.9 90
➖ /codebase/client/utils.js 88 71.42 90 91.66
➖ /codebase/client/ErrorHandlerManager/ErrorHandlerManager.js 100 90 100 100
➖ /codebase/client/TransitionManager/NamedTransitionBlocker.js 100 100 100 100
➖ /codebase/client/TransitionManager/TransitionBlocker.js 100 83.33 100 100
➖ /codebase/client/TransitionManager/TransitionBlockerList.js 84.21 50 84.61 80
➖ /codebase/client/TransitionManager/TransitionManager.js 89.92 77.77 88.46 89.76
➖ /codebase/client/TransitionManager/GlobalSpinner/GlobalSpinner.js 100 100 100 100
➖ /codebase/client/TransitionManager/SlotRenderObserver/SlotRenderObserver.js 85.18 77.77 100 83.33
➖ /codebase/client/TransitionManager/UrlHashController/UrlHashController.js 88.23 66.66 100 88.23
➖ /codebase/client/configuration/IlcConfigRoot.js 86.95 50 91.66 86.95
➖ /codebase/client/configuration/SystemJSImportMap.js 86.66 75 100 86.66
➖ /codebase/client/configuration/getIlcConfigRoot.js 100 100 100 100
➖ /codebase/client/constants/ilcEvents.js 100 100 100 100
➖ /codebase/client/constants/singleSpaEvents.js 100 100 100 100
➖ /codebase/client/errors/BaseError.js 100 80 100 100
➖ /codebase/client/errors/CorsError.js 100 100 100 100
➖ /codebase/client/errors/CriticalFragmentError.js 100 100 100 100
➖ /codebase/client/errors/CriticalInternalError.js 100 100 100 100
➖ /codebase/client/errors/CriticalRuntimeError.js 100 100 100 100
➖ /codebase/client/errors/FetchTemplateError.js 100 100 100 100
➖ /codebase/client/errors/FragmentError.js 100 100 100 100
➖ /codebase/client/errors/InternalError.js 100 100 100 100
➖ /codebase/client/errors/NavigationError.js 100 100 100 100
➖ /codebase/client/errors/RuntimeError.js 100 100 100 100
➖ /codebase/client/errors/UnhandledError.js 100 100 100 100
➖ /codebase/client/errors/index.js 100 100 100 100
➖ /codebase/client/navigationEvents/index.js 100 100 100 100
➖ /codebase/client/navigationEvents/setupEvents.js 87.8 83.33 94.11 87.5
➖ /codebase/common/Environment.js 100 100 100 100
➖ /codebase/common/SdkOptions.js 16.66 0 0 16.66
➖ /codebase/common/UrlProcessor.js 100 100 100 100
➖ /codebase/common/constants.js 100 100 100 100
➖ /codebase/common/i18nCookie.js 80 71.42 100 80
➖ /codebase/common/localStorage.js 48.14 0 11.11 48.14
🔴 /codebase/common/utils.js 40 (-0.62) 21.42 (0) 22.22 (2.22) 42.85 (-1.97)
➖ /codebase/common/wrapWithCache.js 100 80 100 100
➖ /codebase/common/Slot/Slot.js 83.33 100 75 83.33
➖ /codebase/common/Slot/SlotCollection.js 87.5 50 100 87.5
➖ /codebase/common/Slot/SpaSlot.js 92.3 100 83.33 92.3
➖ /codebase/common/Slot/SpaSlotCollection.js 88.88 100 66.66 94.11
➖ /codebase/common/Slot/test/fixture.js 100 100 100 100
➖ /codebase/common/guard/actionTypes.js 100 100 100 100
➖ /codebase/common/guard/errors.js 100 100 100 100
➖ /codebase/common/router/Router.js 98.27 93.54 100 98.27
➖ /codebase/common/router/errors.js 100 100 100 100

Registry

Commit SHA:ae97d9aec63b155dce9123969f7baa82a92e4a73

Test coverage results 🧪

Code coverage diff between base branch:master and head branch: bugfix/triple-slash
File details
Status File % Stmts % Branch % Funcs % Lines
➖ total 80.15 62.93 68.09 80.43
➖ /codebase/newrelic.js 100 50 100 100
➖ /codebase/server.plugins.manifest.ts 100 100 100 100
➖ /codebase/client/babel.config.js 0 100 100 0
➖ /codebase/client/webpack.config.js 0 0 100 0
➖ /codebase/client/src/authProvider.js 0 0 0 0
➖ /codebase/client/src/constants.js 0 100 100 0
➖ /codebase/client/src/dataProvider.js 0 0 0 0
➖ /codebase/client/src/httpClient.js 0 0 0 0
➖ /codebase/client/src/validators.js 0 0 0 0
➖ /codebase/client/src/Localization/en.js 0 0 0 0
➖ /codebase/client/src/Localization/index.js 0 0 0 0
➖ /codebase/client/src/appRoutes/dataTransform.js 0 0 0 0
➖ /codebase/client/src/appRoutes/index.js 0 0 0 0
➖ /codebase/client/src/apps/dataTransform.js 0 0 0 0
➖ /codebase/client/src/apps/index.js 0 0 0 0
➖ /codebase/client/src/authEntities/dataTransform.js 0 0 0 0
➖ /codebase/client/src/authEntities/index.js 0 0 0 0
➖ /codebase/client/src/components/index.js 0 0 0 0
➖ /codebase/client/src/routerDomains/dataTransform.js 0 0 0 0
➖ /codebase/client/src/routerDomains/index.js 0 0 0 0
➖ /codebase/client/src/settings/dataTransform.js 0 0 0 0
➖ /codebase/client/src/settings/index.js 0 0 0 0
➖ /codebase/client/src/settings/hooks/useQueryParams.js 0 0 0 0
➖ /codebase/client/src/settings/hooks/useSettingsEditController.js 0 0 0 0
➖ /codebase/client/src/sharedLibs/dataTransform.js 0 0 0 0
➖ /codebase/client/src/sharedLibs/index.js 0 0 0 0
➖ /codebase/client/src/sharedProps/dataTransform.js 0 0 0 0
➖ /codebase/client/src/sharedProps/index.js 0 0 0 0
➖ /codebase/client/src/templates/dataTransform.js 0 100 0 0
➖ /codebase/client/src/templates/index.js 0 0 0 0
➖ /codebase/client/src/utils/json.js 0 0 0 0
➖ /codebase/client/src/versioning/dataTransform.js 0 0 0 0
➖ /codebase/client/src/versioning/index.js 0 0 0 0
➖ /codebase/server/app.ts 100 60 100 100
➖ /codebase/server/auth.ts 86.52 72.58 94.74 86.52
➖ /codebase/server/index.ts 0 100 0 0
➖ /codebase/server/runnerAssetsDiscovery.ts 0 0 100 0
➖ /codebase/server/server.ts 0 0 0 0
➖ /codebase/server/appRoutes/interfaces/index.ts 96.43 87.5 100 96.43
➖ /codebase/server/appRoutes/routes/createAppRoute.ts 97.3 90 100 97.22
➖ /codebase/server/appRoutes/routes/deleteAppRoute.ts 100 100 100 100
➖ /codebase/server/appRoutes/routes/getAppRoute.ts 100 100 100 100
➖ /codebase/server/appRoutes/routes/getAppRoutes.ts 89.47 70 100 89.47
➖ /codebase/server/appRoutes/routes/index.ts 100 100 100 100
➖ /codebase/server/appRoutes/routes/routesRepository.ts 100 100 100 100
➖ /codebase/server/appRoutes/routes/updateAppRoute.ts 100 100 100 100
➖ /codebase/server/appRoutes/services/prepareAppRoute.ts 100 71.43 100 100
➖ /codebase/server/appRoutes/services/transformSpecialRoutes.ts 100 100 100 100
➖ /codebase/server/apps/interfaces/index.ts 87.5 83.33 66.67 87.5
➖ /codebase/server/apps/routes/createApp.ts 100 100 100 100
➖ /codebase/server/apps/routes/deleteApp.ts 100 100 100 100
➖ /codebase/server/apps/routes/getApp.ts 100 100 100 100
➖ /codebase/server/apps/routes/getApps.ts 76.47 50 100 76.47
➖ /codebase/server/apps/routes/index.ts 100 100 100 100
➖ /codebase/server/apps/routes/updateApp.ts 96.3 87.5 100 96.3
➖ /codebase/server/authEntities/interfaces.ts 100 100 100 100
➖ /codebase/server/authEntities/routes/create.ts 100 50 100 100
➖ /codebase/server/authEntities/routes/deleteRoute.ts 100 100 100 100
➖ /codebase/server/authEntities/routes/get.ts 100 100 100 100
➖ /codebase/server/authEntities/routes/getAll.ts 100 100 100 100
➖ /codebase/server/authEntities/routes/index.ts 100 100 100 100
➖ /codebase/server/authEntities/routes/update.ts 100 75 100 100
➖ /codebase/server/common/services/json.ts 74.29 66.67 90 75.76
➖ /codebase/server/common/services/preProcessResponse.ts 85.71 100 0 85.71
➖ /codebase/server/common/services/validateRequest.ts 89.47 50 100 88.89
➖ /codebase/server/common/services/assets/AssetsDiscovery.ts 0 0 0 0
➖ /codebase/server/common/services/assets/AssetsDiscoveryProcessor.ts 70.59 50 75 70.59
➖ /codebase/server/common/services/assets/AssetsDiscoveryWhiteLists.ts 0 100 100 0
➖ /codebase/server/common/services/assets/AssetsManifestReader.ts 100 100 100 100
➖ /codebase/server/common/services/assets/AssetsValidator.ts 100 100 100 100
➖ /codebase/server/common/services/assets/assetsManifestProcessor.ts 100 100 100 100
➖ /codebase/server/common/services/assets/errors/AssetsManifestError.ts 100 100 100 100
➖ /codebase/server/common/services/entries/ApplicationEntry.ts 95.35 78.57 100 95.35
➖ /codebase/server/common/services/entries/Entry.ts 0 0 0 0
➖ /codebase/server/common/services/entries/EntryFactory.ts 95 87.5 100 95
➖ /codebase/server/common/services/entries/SharedLibEntry.ts 97.14 87.5 100 97.14
➖ /codebase/server/common/services/entries/error/EntryError.ts 100 100 100 100
➖ /codebase/server/common/services/entries/error/IncorrectEntryError.ts 100 100 100 100
➖ /codebase/server/common/services/entries/error/NotFoundApplicationError.ts 100 100 100 100
➖ /codebase/server/common/services/entries/error/NotFoundFqrnError.ts 100 100 100 100
➖ /codebase/server/common/services/entries/error/NotFoundSharedLibraryError.ts 100 100 100 100
➖ /codebase/server/common/services/entries/error/ValidationFqrnError.ts 100 100 100 100
➖ /codebase/server/db/index.ts 85 50 60 88.89
➖ /codebase/server/db/logger.ts 42.86 100 20 42.86
➖ /codebase/server/db/range.ts 100 100 100 100
➖ /codebase/server/db/structure.ts 100 100 100 100
➖ /codebase/server/db/versioning.ts 85.71 50 100 85.71
➖ /codebase/server/entries/entries.ts 87.1 60 100 87.1
➖ /codebase/server/errorHandler/httpErrors.ts 100 100 100 100
➖ /codebase/server/errorHandler/index.ts 100 100 100 100
➖ /codebase/server/errorHandler/noticeError.ts 100 0 100 100
➖ /codebase/server/middleware/context.ts 100 75 100 100
➖ /codebase/server/middleware/userContext.ts 100 100 100 100
➖ /codebase/server/migrations/20191016185102_apps.ts 100 100 66.67 100
➖ /codebase/server/migrations/20191017131220_templates.ts 100 100 66.67 100
➖ /codebase/server/migrations/20191017131749_routes.ts 100 100 66.67 100
➖ /codebase/server/migrations/20191017144455_route_slots.ts 100 100 66.67 100
➖ /codebase/server/migrations/20200113141956_apps.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20200113142437_route_slots.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20200120162838_apps_config_selector.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20200121110723_shared_props.ts 83.33 100 66.67 83.33
➖ /codebase/server/migrations/20200409184919_auth_entitites.ts 100 100 66.67 100
➖ /codebase/server/migrations/20200409190157_auth_entitites_default.ts 100 100 50 100
➖ /codebase/server/migrations/20200410180130_sessions.ts 88.89 50 75 88.89
➖ /codebase/server/migrations/20200518134531_apps_initProps_removal.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20200729141256_settings.ts 100 100 66.67 100
➖ /codebase/server/migrations/20201012152003_settings_meta.ts 58.33 100 50 58.33
➖ /codebase/server/migrations/20201013140633_settings_default.ts 90.91 50 75 90.91
➖ /codebase/server/migrations/20201027180112_settings_globalSpinner.ts 80 100 50 80
➖ /codebase/server/migrations/20201028142200_settings_i18n.ts 80 100 50 80
➖ /codebase/server/migrations/20201029122727_settings_AuthOpenIdUniqueIdentifierClaimName.ts 80 100 50 80
➖ /codebase/server/migrations/20201105155522_versioning.ts 90.91 100 66.67 90.91
➖ /codebase/server/migrations/20201130141801_i18n_enabled_by_default.ts 80 100 50 80
➖ /codebase/server/migrations/20201228201314_route_meta.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210125185210_app_wrapper_kind.ts 76.47 25 80 76.47
➖ /codebase/server/migrations/20210125185211_apps_wrappedWith.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210219174348_settings_overrideConfigTrustedOrigins.ts 80 100 50 80
➖ /codebase/server/migrations/20210226191151_apps_ssrProps.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210226191205_shared_props_ssrProps.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210405164831_router_domains.ts 85.71 100 66.67 85.71
➖ /codebase/server/migrations/20210405182655_routes_domainId.ts 63.46 37.5 60.87 63.46
➖ /codebase/server/migrations/20210426163602_routes_orderPosIsNullable.ts 66 37.5 56 66
➖ /codebase/server/migrations/20210430154258_routes_uniqfromSpecialRoleToRoute.ts 62.5 100 50 62.5
➖ /codebase/server/migrations/20210430154639_routes_moveSpecialRolesToRoute.ts 35.29 0 37.5 35.29
➖ /codebase/server/migrations/20210430155514_routes_removeColumnSpecialRole.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210505151225_routes_domainIdIdxble.ts 45.45 25 33.33 45.45
➖ /codebase/server/migrations/20210505181754_routes_orderPos_unique_per_domain.ts 62.5 100 50 62.5
➖ /codebase/server/migrations/20210505182004_routes_route_unique_per_domain.ts 62.5 100 50 62.5
➖ /codebase/server/migrations/20210505182425_old_tbls_cleanup.ts 80 25 50 80
➖ /codebase/server/migrations/20210521125202_routes_drop_unique_route.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210607160910_apps_discoveryMetadata.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210607161242_apps_adminNotes.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20210625150840_roles_userToReadonly.ts 50 25 50 50
➖ /codebase/server/migrations/20210701183133_auth_entity_readonly.ts 80 100 50 80
➖ /codebase/server/migrations/20210826144904_shared_libs.ts 88.89 100 66.67 88.89
➖ /codebase/server/migrations/20220121115756_settings_onPropsUpdate.ts 80 100 50 80
➖ /codebase/server/migrations/20220315155008_increase-template-size.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20220316133143_versioning-text-update.ts 62.5 100 50 62.5
➖ /codebase/server/migrations/20220323123155_add-locale-to-template.ts 88.89 100 66.67 88.89
➖ /codebase/server/migrations/20220520083801_apps_enforceDomain.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20220815164948_l20nManifest.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20220819204836_rename-use-l10n.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20220928161155_shared-lib-add-localization.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20221118164122_add_csp_settings.ts 80 100 50 80
➖ /codebase/server/migrations/20221123163817_csp-available-host-for-local.ts 80 100 50 80
➖ /codebase/server/migrations/20221201191407_csp_enable_scrict_mode.ts 100 100 50 100
➖ /codebase/server/migrations/20230303174003_settings-add-primary-key.ts 66.67 100 50 66.67
➖ /codebase/server/migrations/20230303175443_settings-domain-value-table.ts 90 100 66.67 90
➖ /codebase/server/migrations/20230703130802_remove-spa-bundle-constraint.ts 66.67 100 50 66.67
➖ /codebase/server/public/interfaces.ts 0 0 0 0
➖ /codebase/server/public/routes/appDiscovery.ts 100 100 100 100
➖ /codebase/server/public/routes/index.ts 100 100 100 100
➖ /codebase/server/routerDomains/interfaces/index.ts 90.91 75 100 90.91
➖ /codebase/server/routerDomains/routes/createRouterDomains.ts 100 100 100 100
➖ /codebase/server/routerDomains/routes/deleteRouterDomains.ts 100 100 100 100
➖ /codebase/server/routerDomains/routes/getAllRouterDomains.ts 100 100 100 100
➖ /codebase/server/routerDomains/routes/getRouterDomains.ts 100 100 100 100
➖ /codebase/server/routerDomains/routes/index.ts 100 100 100 100
➖ /codebase/server/routerDomains/routes/updateRouterDomains.ts 100 100 100 100
➖ /codebase/server/routes/config.ts 98.25 57.89 91.67 98.11
➖ /codebase/server/routes/routes.ts 100 100 100 100
➖ /codebase/server/seeds/00_cleanup.ts 100 50 100 100
➖ /codebase/server/seeds/01_apps.ts 100 100 100 100
➖ /codebase/server/seeds/02_templates.ts 100 100 100 100
➖ /codebase/server/seeds/03_routerDomains.ts 100 100 100 100
➖ /codebase/server/seeds/04_routes.ts 100 100 100 100
➖ /codebase/server/seeds/05_route_slots.ts 100 100 100 100
➖ /codebase/server/seeds/06_settings.ts 90.91 50 100 90.91
➖ /codebase/server/seeds/07_rootPwd.ts 83.33 50 100 83.33
➖ /codebase/server/settings/interfaces/cspSchema.ts 100 100 100 100
➖ /codebase/server/settings/interfaces/index.ts 100 100 100 100
➖ /codebase/server/settings/routes/createSetting.ts 100 100 100 100
➖ /codebase/server/settings/routes/deleteDomainSetting.ts 100 100 100 100
➖ /codebase/server/settings/routes/getSetting.ts 80 50 100 80
➖ /codebase/server/settings/routes/getSettings.ts 100 77.78 100 100
➖ /codebase/server/settings/routes/index.ts 100 100 100 100
➖ /codebase/server/settings/routes/updateSetting.ts 83.33 50 100 83.33
➖ /codebase/server/settings/services/SettingsService.ts 80.39 75.71 84.62 87.91
➖ /codebase/server/settings/services/preProcessResponse.ts 92.86 100 50 92.86
➖ /codebase/server/sharedLibs/interfaces/index.ts 100 100 100 100
➖ /codebase/server/sharedLibs/routes/createSharedLib.ts 95 75 100 95
➖ /codebase/server/sharedLibs/routes/deleteSharedLib.ts 100 100 100 100
➖ /codebase/server/sharedLibs/routes/getSharedLib.ts 100 100 100 100
➖ /codebase/server/sharedLibs/routes/getSharedLibs.ts 100 100 100 100
➖ /codebase/server/sharedLibs/routes/index.ts 100 100 100 100
➖ /codebase/server/sharedLibs/routes/updateSharedLib.ts 92.59 75 100 92.59
➖ /codebase/server/sharedProps/interfaces/index.ts 100 100 100 100
➖ /codebase/server/sharedProps/routes/createSharedProps.ts 100 100 100 100
➖ /codebase/server/sharedProps/routes/deleteSharedProps.ts 100 100 100 100
➖ /codebase/server/sharedProps/routes/getAllSharedProps.ts 100 100 100 100
➖ /codebase/server/sharedProps/routes/getSharedProps.ts 100 100 100 100
➖ /codebase/server/sharedProps/routes/index.ts 100 100 100 100
➖ /codebase/server/sharedProps/routes/updateSharedProps.ts 100 100 100 100
➖ /codebase/server/templates/errors.ts 100 100 100 100
➖ /codebase/server/templates/interfaces/index.ts 0 0 0 0
➖ /codebase/server/templates/routes/createTemplate.ts 96 100 100 96
➖ /codebase/server/templates/routes/deleteTemplate.ts 100 100 100 100
➖ /codebase/server/templates/routes/getRenderedTemplate.ts 81.4 75 100 81.4
➖ /codebase/server/templates/routes/getTemplate.ts 100 100 100 100
➖ /codebase/server/templates/routes/getTemplates.ts 100 100 100 100
➖ /codebase/server/templates/routes/index.ts 100 100 100 100
➖ /codebase/server/templates/routes/updateTemplate.ts 95.65 83.33 100 95.65
➖ /codebase/server/templates/routes/validation.ts 100 100 100 100
➖ /codebase/server/templates/services/parseLinkHeader.ts 100 100 100 100
➖ /codebase/server/templates/services/renderTemplate.ts 97.33 93.33 100 97.1
➖ /codebase/server/templates/services/templatesRepository.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/Attributes.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/Resource.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/ResourceLinkParser.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/ResourcePreload.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/ResourceScript.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/ResourceStylesheet.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/buildAttributes.ts 100 100 100 100
➖ /codebase/server/templates/services/resources/filterObject.ts 100 100 100 100
➖ /codebase/server/util/TemplateParser.ts 100 100 100 100
➖ /codebase/server/util/TypedMap.ts 100 100 100 100
➖ /codebase/server/util/express-promise.ts 80 81.82 100 80
➖ /codebase/server/util/helpers.ts 100 100 100 100
➖ /codebase/server/util/isMySQL.ts 100 100 100 100
➖ /codebase/server/util/isTemplateValid.ts 87.5 75 100 87.5
➖ /codebase/server/util/logger.ts 83.33 92.31 50 82.93
➖ /codebase/server/util/ping.ts 50 100 0 50
➖ /codebase/server/util/pluginManager.ts 100 100 100 100
➖ /codebase/server/versioning/config.ts 100 100 100 100
➖ /codebase/server/versioning/errors.ts 100 100 100 100
➖ /codebase/server/versioning/interfaces.ts 100 100 100 100
➖ /codebase/server/versioning/routes/getVersions.ts 84.62 66.67 100 84.62
➖ /codebase/server/versioning/routes/index.ts 100 100 100 100
➖ /codebase/server/versioning/routes/revertVersion.ts 53.33 0 100 53.33
➖ /codebase/server/versioning/services/Versioning.ts 75.29 73.08 83.33 76.83
➖ /codebase/tests/common.ts 91.67 50 100 88.89
➖ /codebase/tests/utils/console.ts 100 100 100 100
➖ /codebase/tests/utils/withSetting.ts 100 100 100 100
➖ /codebase/typings/index.d.ts 0 0 0 0
➖ /codebase/typings/knex/index.d.ts 0 0 0 0

@stas-nc stas-nc merged commit ea75cd9 into master Oct 4, 2023
@stas-nc stas-nc deleted the bugfix/triple-slash branch October 4, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yehor-manzhula yehor-manzhula yehor-manzhula approved these changes

@blackrabbit99 blackrabbit99 Awaiting requested review from blackrabbit99

@b1ff b1ff Awaiting requested review from b1ff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stas-nc @yehor-manzhula