feat(registry): add PostgreSQL support #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a857226 to
36a5290
Compare
ac11db1 to
ef598ad
Compare
5aaf05f to
0aefd67
Compare
0aefd67 to
752d5d5
Compare
b1ff
reviewed
Sep 29, 2023
| return Object.fromEntries(Object.entries(value).map(([key, value]) => [key, parseJSON(value)])) as T; | ||
| } else { | ||
| return parse(value); | ||
| } |
752d5d5 to
cb59916
Compare
blackrabbit99
approved these changes
Sep 29, 2023
|
|
||
| export default async (withAuth: boolean = true): Promise<Application> => { | ||
| loadPlugins(); | ||
| logConnectionString(); |
There was a problem hiding this comment.
why do we need to log connection string ?
| import { retrieveAppRouteFromDB } from './getAppRoute'; | ||
| import { transformSpecialRoutesForDB } from '../services/transformSpecialRoutes'; | ||
| import { getJoiErr, joiErrorToResponse } from '../../util/helpers'; | ||
| import { defined, getJoiErr, joiErrorToResponse } from '../../util/helpers'; |
There was a problem hiding this comment.
defined helper looks like a kind of magic for me. What is its purpose ?
|
|
||
| export async function up(knex: Knex): Promise<any> { | ||
| if (isMySQL(knex)) { | ||
| if (!isSqlite(knex)) { |
There was a problem hiding this comment.
Maybe it makes sense to remove SqlLite at all to not support this logical branch ?
b1ff
reviewed
Sep 29, 2023
| import type Knex from 'knex'; | ||
| import { isPostgres } from '../util/db'; | ||
|
|
||
| export function syncSequencePlugin(knex: typeof Knex): void { |
There was a problem hiding this comment.
seems a little hacky, why does it needed?
| import app from './app'; | ||
| import server from './server'; | ||
| import { getLogger } from './util/logger'; | ||
|
|
||
| process.env.NODE_CONFIG_DIR = path.resolve(__dirname, '../config'); |
There was a problem hiding this comment.
are you sure that this line is not needed? It seems that it resolves to a correct newrelic config file
| @@ -2,7 +2,7 @@ import { Knex } from 'knex'; | |||
|
|
|||
| export async function up(knex: Knex): Promise<any> { | |||
| return knex.schema.table('routes', (table) => { | |||
| table.text('meta'); | |||
| table.json('meta'); | |||
There was a problem hiding this comment.
not sure that we can change existing migrations... if you expect json next in the code, it might not be applied to real DBs
| loadPlugins(); | ||
| new AssetsDiscovery('apps').start(interval); | ||
| new AssetsDiscovery('shared_libs').start(interval); | ||
| (async () => { |
| @@ -63,11 +63,11 @@ export enum OnPropsUpdateValues { | |||
| Update = 'update', | |||
| } | |||
|
|
|||
| type SettingValue = string | boolean | TrailingSlashValues | string[]; | |||
| type SettingValue = string | number | boolean | string[]; | |||
There was a problem hiding this comment.
TrailingSlashValues seems missed, but it should be there
| err.message.includes(v), | ||
| ) | ||
| ) { | ||
| throw new ForeignConstraintError(); |
There was a problem hiding this comment.
we need message here, otherwise will be verry hard to debug
yehor-manzhula
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
What for do we need this file?
dd38744 to
24ed823
Compare
configure local development for using different databases adapt migrations to PostgreSQL adapt codebase for using PostgreSQL normalize api responses between databases extend and fix typings prepare CI for test running on multiple databases add configuration via dotenv (for local development)
24ed823 to
2eeaf83
Compare
Coverage ReportIlc/serverCommit SHA:6c2109bcdefa0f63039f93645b1044d0ba759c51 Test coverage results 🧪File details
Ilc/clientCommit SHA:6c2109bcdefa0f63039f93645b1044d0ba759c51 Test coverage results 🧪File details
RegistryCommit SHA:6c2109bcdefa0f63039f93645b1044d0ba759c51 Test coverage results 🧪File details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure local development for using different databases
adapt migrations to PostgreSQL
adapt codebase for using PostgreSQL
normalize api responses between databases
extend and fix typings
prepare CI for test running on multiple databases
add configuration via dotenv (for local development)