fix(errors): Hardcode error names instead of using constructor.name a… #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd rely on minifier options
b1ff
approved these changes
Oct 25, 2022
b1ff
approved these changes
Oct 25, 2022
ilc/client/errors/BaseError.spec.js
Outdated
|
|
||
| it('should set correct child name', () => { | ||
| const Child = BaseError.extends('ChildError'); | ||
| expect(new Child().name).to.be.instanceOf('ChildError'); |
There was a problem hiding this comment.
just to.be.equal('ChildError') should be enough
b4c6d29 to
dd53062
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardcode error names instead of using constructor.name and rely on minifier options