feat: add ability to customize static error page. #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now customer can specify its own error page if default is not suitable. Also default error page now is a valid HTML and more pretty than just text.
blackrabbit99
requested changes
Jul 20, 2022
| const staticFilePath = config.get('staticError.disasterFileContentPath'); | ||
| try { | ||
| if (staticFilePath != null) { | ||
| this.#staticFileContent = readFileSync(staticFilePath).toString(); |
There was a problem hiding this comment.
why sync ?
Maybe it makes sence serve it from memory ?
There was a problem hiding this comment.
that is an idea. It is put into memory on first read
There was a problem hiding this comment.
you are welcome, can you approve PR?)
blackrabbit99
approved these changes
Jul 21, 2022
… discussion with designers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now customer can specify its own error page if default is not suitable. Also default error page now is a valid HTML and more pretty than just text.