Skip to content

Refactor the config into a package #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2024
Merged

Refactor the config into a package #3

merged 2 commits into from
Jan 9, 2024

Conversation

stefanprodan
Copy link
Contributor

Changes:

  • Move the config to a dedicated package
  • Spit the config from the instance
  • Move the defaults from values.cue to the config definitions

stefanprodan and others added 2 commits January 9, 2024 10:55
@stefanprodan
Refactor the config into a package
fa36e5b 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@nalum
Merge branch 'main' into config-refactorig
17de554
@nalum nalum marked this pull request as ready for review January 9, 2024 10:24
@nalum nalum merged commit a65c9b1 into nalum:main Jan 9, 2024
@nalum
Copy link
Owner

nalum commented Jan 10, 2024

Apologies, I didn't thank you before merging this. 🙇 Thank you @stefanprodan 😄

@stefanprodan stefanprodan deleted the config-refactorig branch January 10, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalum nalum nalum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @nalum