Describe issues found as complex nested instead of deeply nested #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complexity is not about just nesting depth, there are other considerations. Closes #8
|
This approach changes all occurrences of the messages to the one discussed in #8. I think that's fine, even though the original report there kind of implicitly asked to separate nesting and other kind of complexity. That seems much more work than it's worth, we can keep it simple like here. |
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
=======================================
Coverage 76.85% 76.85%
=======================================
Files 3 3
Lines 216 216
=======================================
Hits 166 166
Misses 38 38
Partials 12 12
Continue to review full report at Codecov.
|
nakabonne
approved these changes
Oct 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complexity is not about just nesting depth, there are other considerations.
Closes #8