Do not split --header flag into multiple values #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces pflag.StringSliceVarP with pflag.StringArrayVarP and thus disallows multiple headers to be defined with a single flag. Compare https://pkg.go.dev/github.com/spf13/pflag#StringSliceVar for details. The previous implementation did not allow header values to contain a comma, this change fixes that.
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 72.33% 72.33%
=======================================
Files 9 9
Lines 589 589
=======================================
Hits 426 426
Misses 130 130
Partials 33 33
Continue to review full report at Codecov.
|
nakabonne
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces pflag.StringSliceVarP with pflag.StringArrayVarP and thus
disallows multiple headers to be defined with a single flag.
Compare https://pkg.go.dev/github.com/spf13/pflag#StringSliceVar
for details.
The previous implementation did not allow header values to contain
a comma, this change fixes that.