Skip to content

Conversation

markruler
Copy link
Contributor

Related: #50

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #54 into master will increase coverage by 0.09%.
The diff coverage is 83.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   77.72%   77.81%   +0.09%     
==========================================
  Files           8        8              
  Lines         377      383       +6     
==========================================
+ Hits          293      298       +5     
- Misses         65       66       +1     
  Partials       19       19              
Impacted Files Coverage Δ
attacker/attacker.go 67.45% <66.67%> (-0.05%) ⬇️
main.go 80.56% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cccdee3...6a2592d. Read the comment docs.

@nakabonne
Copy link
Owner

@markruler Hi, thanks for your contribution! Could you perform gofmt -s and then push again?

Copy link
Owner

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I appreciate your help!

@nakabonne nakabonne merged commit 2a36d9a into nakabonne:master Oct 8, 2020
@nakabonne nakabonne mentioned this pull request Oct 8, 2020
1 task
@markruler markruler deleted the support-local-address branch October 8, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants