Skip to content

Closing metrics channel #52

@nakabonne

Description

@nakabonne

Because of a closed channel before the function returns, there is a certain probability of panic:

defer close(d.metricsCh)

This is for waiting until the expected method is called in a goroutine in the unit test.

<-d.metricsCh

We need another way to pass the tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions