-
Notifications
You must be signed in to change notification settings - Fork 152
Closed
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers
Description
Because of a closed channel before the function returns, there is a certain probability of panic:
Line 104 in fd4e04b
defer close(d.metricsCh) |
This is for waiting until the expected method is called in a goroutine in the unit test.
Line 264 in fd4e04b
<-d.metricsCh |
We need another way to pass the tests.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomers