Skip to content

Conversation

dharsanb
Copy link

@dharsanb dharsanb commented Dec 15, 2024

Fixes issue: #191 (comment)

Please feel free to modify the PR as necessary.

@dharsanb
Copy link
Author

Also, can you please setup approvals to run CI on GitHub when commits are not from the owners of the repo. Think this exists for DroneCI but not for GitHub actions.
Once the linter issue is fixed you can also mark the CI steps as required.

@naggie
Copy link
Owner

naggie commented Dec 16, 2024

Awesome thanks @dharsanb

@naggie naggie merged commit a13098b into naggie:master Dec 16, 2024
1 of 2 checks passed
@naggie
Copy link
Owner

naggie commented Dec 16, 2024

I'll check the settings later 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants