Rework notifications for new tickets to use hook #776
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR reworks the ticket notification system to use hooks instead of handling notifications directly in the ticket insertion process. The change moves notification logic from the insert_tickets hook to the ticket_opened handler, providing better separation of concerns and more granular control over when notifications are created.
Key changes:
- Moved notification creation logic from insert_tickets hook to ticket_opened handler
- Updated goflow dependency to version 0.255.1
- Refactored notification helper functions and removed obsolete test code
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates goflow dependency to version 0.255.1 |
| core/runner/hooks/insert_tickets.go | Removes notification creation logic from ticket insertion hook |
| core/runner/handlers/ticket_opened.go | Adds notification logic using InsertNotifications hook |
| core/models/notification_test.go | Removes obsolete test for ticket notifications |
| core/models/notification.go | Refactors notification functions and fixes typo in variable name |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -85,28 +86,18 @@ func NotifyIncidentStarted(ctx context.Context, db DBorTx, oa *OrgAssets, incide | |||
| return InsertNotifications(ctx, db, notifications) | |||
| } | |||
|
|
|||
| var ticketAssignableToles = []UserRole{UserRoleAdministrator, UserRoleEditor, UserRoleAgent} | |||
| var ticketAssignableRoles = []UserRole{UserRoleAdministrator, UserRoleEditor, UserRoleAgent} | |||
There was a problem hiding this comment.
Fixed typo in variable name from 'ticketAssignableToles' to 'ticketAssignableRoles'.
Copilot uses AI. Check for mistakes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 50.74% 50.66% -0.09%
==========================================
Files 256 256
Lines 15220 15211 -9
==========================================
- Hits 7723 7706 -17
- Misses 6696 6704 +8
Partials 801 801 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.