Create legacy ticket opened events with engine event UUID #774
+45
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates ticket event creation to accept an explicit UUID parameter instead of generating one internally, enabling legacy ticket opened events to use the engine event UUID for consistency.
Key changes:
- Modified all ticket event constructor functions to accept a
flows.EventUUIDparameter - Updated ticket opened event creation to use the engine event's UUID from the flow event
- Restructured the ticket hook to pass the entire flow event instead of just the note
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/models/ticket_event.go | Updated constructor functions to accept UUID parameter instead of generating internally |
| core/models/ticket_event_test.go | Updated test cases to provide explicit UUIDs and add UUID assertions |
| core/runner/hooks/insert_tickets.go | Modified to store and use flow events for UUID extraction |
| core/runner/handlers/ticket_opened.go | Updated to pass entire event object instead of just note |
| core/models/ticket.go | Updated all ticket event creation calls to generate UUIDs |
| core/tasks/realtime/ctasks/ticket_closed_test.go | Updated test to provide UUID parameter |
| core/models/notification_test.go | Updated test helper to provide UUID parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ac0fc5c to
832e4f2
Compare
rowanseymour
commented
Sep 1, 2025
| @@ -1647,19 +1647,19 @@ | |||
| }, | |||
| "events": [ | |||
| { | |||
| "uuid": "01969b47-76cb-76f8-ba91-c48ad8c50e6b", | |||
There was a problem hiding this comment.
we're calling uuids.NewV7 one less time
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
==========================================
- Coverage 50.88% 50.88% -0.01%
==========================================
Files 253 253
Lines 15197 15198 +1
==========================================
Hits 7733 7733
- Misses 6661 6662 +1
Partials 803 803 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.