Update to latest goflow which adds new event types for channel "events" #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Updates the project to use the latest version of the goflow library (v0.254.1) which introduces new specific event types for channel events, replacing generic trigger methods with more specific ones.
Key changes:
- Update goflow dependency from v0.253.2 to v0.254.1
- Replace generic trigger methods (Msg, Ticket, Channel, etc.) with specific event type methods (MsgReceived, TicketClosed, CallReceived, etc.)
- Refactor event handling to use new specific event types instead of generic channel events
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates goflow dependency to v0.254.1 |
| web/simulation/simulation.go | Replaces generic Msg() with specific MsgReceived() trigger method |
| core/tasks/realtime/ctasks/ticket_closed.go | Replaces generic Ticket() with specific TicketClosed() trigger method |
| core/tasks/realtime/ctasks/msg_received.go | Replaces generic Msg() with specific MsgReceived() trigger method |
| core/tasks/realtime/ctasks/event_received.go | Refactors to use specific event trigger methods and removes generic parameter handling |
| core/tasks/campaigns/bulk_campaign_trigger.go | Replaces generic Campaign() with specific CampaignFired() trigger method |
| core/runner/handlers/noop.go | Registers handlers for new event types (CallMissed, ChatStarted) |
| core/runner/handlers/base_test.go | Updates test to use specific MsgReceived() trigger method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0372257 to
9dec960
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #763 +/- ##
==========================================
+ Coverage 51.02% 51.03% +0.01%
==========================================
Files 250 250
Lines 15100 15102 +2
==========================================
+ Hits 7705 7708 +3
+ Misses 6588 6587 -1
Partials 807 807 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.