fix(kit): update generated tsconfig.json with improved defaults
#27485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #25789
📚 Description
This improves types for Nuxt apps (and also within the monorepo), in many cases following recommendations from https://www.totaltypescript.com/tsconfig-cheat-sheet.
The most potentially disruptive changes is enabling
noUncheckedIndexedAccess. I've marked that it only be enabled for v4+ but would be willing to revisit that. It will likely throw up a lot of type warnings, but can easily be disabled, and is a better choice for a new project.As the diff in the PR is a bit messy (tidying up the options by topic/section), here's a simplified version:
compilerOptions: { forceConsistentCasingInFileNames: true, jsx: 'preserve', jsxImportSource: 'vue', - target: 'ESNext', - module: 'ESNext', + target: 'es2022', + module: 'preserve', moduleDetection: 'force', moduleResolution: nuxt.options.future?.typescriptBundlerResolution || (nuxt.options.experimental as any)?.typescriptBundlerResolution ? 'Bundler' : 'Node', skipLibCheck: true, isolatedModules: true, useDefineForClassFields: true, strict: nuxt.options.typescript?.strict ?? true, + noUncheckedIndexedAccess: nuxt.options.future.compatibilityVersion === 4, + noImplicitOverride: true, + lib: [ + 'es2022', + 'dom', + 'dom.iterable' + ], noImplicitThis: true, esModuleInterop: true, types: [], verbatimModuleSyntax: true, allowJs: true, noEmit: true, resolveJsonModule: true, allowSyntheticDefaultImports: true, paths: {}, }@pi0 are you up for a similar PR to nitro?