feat: support compatibility version map (for image) #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
reviewed
Sep 19, 2023
| @@ -27,3 +27,6 @@ compatibility: | |||
| nuxt: ^2.0.0 || ^3.0.0 | |||
| requires: | |||
| bridge: optional | |||
| versionMap: | |||
| 2.x: latest | |||
There was a problem hiding this comment.
would it make sense for the map to be [any semver string]: any semver string rather than requiring it to be a tag?
edit: or maybe this is already what you have in mind
There was a problem hiding this comment.
Yes both sides are semver compatible (righthand is basically whatever npm i pkg@contraint allows)
danielroe
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(context: followup for nuxt/cli#197)
Some Nuxt modules use different major versions for Nuxt compatibility.
This PR adds a new standard
compatibility.versionMap(better names welcome) to support mapping compatible Nuxt version to their Corresponding Module compatible version/tag.