fix: include config dir in tsconfig #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for nuxt-storybook pending review.Visit the deploys page to approve it
|
|
The hoist shouldn't be necessary anymore (was actually more a mistake in the Does the ts fix needs to be safe-guarded by a nuxt version check? |
Okay I have removed the hoist entry.
No, this will add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
pnpmcan't resolve@storybook-vue/nuxtwhen deps not hoisted #920📚 Description
With nuxt/nuxt#32601 merged, the related issue will be resolved for projects using nuxt 4.
This will also improve/add support for the directory structure in nuxt 4 as the
.storybookdirectory is outside the app/server directories and needs to be added manually by this module.If we also want this resolved for projects using nuxt 3, the PR will either need to be backported (ideal) or we could use my package nuxt-module-utils (I have not done so in this PR, I don't want to be pushy with my own packages 😂).(this is not relevant since the separated tsconfig structure is nuxt 4 only)