Skip to content

Conversation

elliotchenzichang
Copy link
Member

fix issue: #159

datafile_test.go Outdated

if err == nil {
t.Error("err invalid argument")
if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?where did this err come from

fd_manager.go Outdated
func newFdm(maxFdNums int, cleanThreshold float64) (fdm *fdManager) {
fdm = &fdManager{
cache: map[string]*FdInfo{},
fdList: initList(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initdoubleLinkedList ?

fd_manager.go Outdated
for node != nil && node != fdm.fdList.head && cleanNums > 0 {
nextItem := node.prev
if node.using == 0 {
fdm.fdList.remoteNode(node)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeNode?

fd_manager.go Outdated
cache map[string]*FdInfo
fdList *doubleLinkedList
size int
cleanThreshold int
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanThresholdNum?

@@ -28,6 +28,7 @@ func (suite *TxBucketTestSuite) SetupSuite() {
}
}
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xujiajun xujiajun added the enhancement New feature or request label May 31, 2022
@xujiajun xujiajun added this to the v0.9.0 milestone May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants