Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nunnatsa/ginkgolinter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.19.0
Choose a base ref
...
head repository: nunnatsa/ginkgolinter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.19.1
Choose a head ref
  • 4 commits
  • 7 files changed
  • 2 contributors

Commits on Feb 13, 2025

  1. Configuration menu
    Copy the full SHA
    95ce7b3 View commit details
    Browse the repository at this point in the history
  2. Improve IsGomegaVar() and IsGomegaType()

    Don't check non ast.Ident expressions for been Gomega variables.
    
    Make more accurate check for the Gomega types (struct or interface).
    check the alias value instead of the alias.
    nunnatsa committed Feb 13, 2025
    Configuration menu
    Copy the full SHA
    a99d92e View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2025

  1. chore: update Unalias

    ldez authored and nunnatsa committed Feb 14, 2025
    Configuration menu
    Copy the full SHA
    d302fe7 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2025

  1. Fix issue: failed to recognize ginkgo.SpecContext in Eventually

    ginkgolinter fails to recognized ginkgo.SpecContext as a valid context in
    Eventually, and so wrongly identify it as the actual value, instead of
    the following function parameter.
    
    This PR fixes the issue and now this scenarion works
    
    ```go
    It("should work", func(ctx SpecContext) {
    	Eventually(func() error {
    		return fmt.Errorf("foo")
    	}).WithContext(ctx).Should(MatchError("foo"))
    }, SpecTimeout(time.Second))
    ```
    nunnatsa committed Feb 18, 2025
    Configuration menu
    Copy the full SHA
    1b633dc View commit details
    Browse the repository at this point in the history
Loading