Skip to content

🐛 fix scalar constructors #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

jorenham
Copy link
Member

@jorenham jorenham commented Feb 4, 2025

With pyright, float64 and complex128 only accepted the same types as builtins.float and builtins.complex, because the __new__ wasn't overridden.

@jorenham jorenham added stubs: Incorrect numpy.generic port: to numpy NumType PR's that should be ported to NumPy labels Feb 4, 2025
@jorenham jorenham added this to the v2.2.x.0 milestone Feb 4, 2025
@jorenham jorenham merged commit bdf1432 into main Feb 4, 2025
1 check passed
@jorenham jorenham deleted the fix-pyright-constructors-float64-complex128 branch February 4, 2025 02:49
@jorenham jorenham changed the title 🐛 fix float64 / complex128 constructors on pyright 🐛 fix scalar constructors Feb 5, 2025
@jorenham jorenham removed the port: to numpy NumType PR's that should be ported to NumPy label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant