BUG: call PyType_Ready in f2py to avoid data races #28133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Nathan. PyType_Ready was new in Python 2.2 (2001) when new style classes were introduced. There used to be two class hierarchies, and I suspect f2py just missed the change. |
|
Thanks for that context! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28122
Chesterton's fence: I have no idea if the lack of a
PyType_Readycall was intentional.That said, it seems to be missing all the way back in 2005 so it may be that f2py has always been implicitly relying on Python finalizing the type and that's been fine until now.