MAINT: update NPY_FEATURE_VERSION after dropping python 3.10 #28993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
approved these changes
May 18, 2025
There was a problem hiding this comment.
LGTM, thanks @h-vetinari. This is consistent with the previous bump when we dropping Python 3.9 support (see gh-27187), so should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28992
Python 3.10 was dropped in #27862, but the corresponding changes to
NPY_FEATURE_VERSIONgot missed. The first release to support Python 3.11 was v1.23.2, so now that Python 3.10 is dropped, the lowest possibleNPY_FEATURE_VERSIONis 1.23.