-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[CI only] Testing #8620 with NumPy versions < 1.24 #8690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
np.bool was removed in NumPy 1.24.
This always produced invalid results (though they were consistent between Numba and NumPy) but now this fails in NumPy 1.24 with an exception: ``` TypeError: The `dtype` and `signature` arguments to ufuncs only select the general DType and not details such as the byte order or time unit. You can avoid this error by using the scalar types `np.float64` or the dtype string notation. ``` Note that the exception message is misleading, and using the dtype string notation does not provide a workaround.
I believe this was written in error and should always have been float16.
The modified regex matches the existing message produced by NumPy < 1.24, and the new improved message in 1.24.
Setting an array element with a sequence is removed in NumPy 1.24.
This is so that a proper solution can be implemented. This reverts commit 08416ad.
`init_ufunc_dispatch()` should set an exception if it's going to fail. Without setting an exception, an unrecognized ufunc method (e.g. `resolve_dtypes()` in NumPy 1.24) results in: ``` SystemError: initialization of _internal failed without raising an exception ``` This commit modifies it to set an exception notifying the user of the error. Now when an unrecognized ufunc method is encountered, the traceback ends in: ``` from numba.np.ufunc import _internal RuntimeError: Unexpected ufunc method resolve_dtypes() ```
The Windows build did not like a variable-length stack array.
The API version has long since been greater than 0x7 / 0x8 for any supported NumPy.
This reverts commit 22980fe.
This test only checked for a plain match when comparing outputs. However, in some cases a reconstruction check can be necessary, as in `test_linalg_svd`.
gpuci run tests |
3593074
to
ce8e9fb
Compare
Merged
From PR numba#8691 feedback.
PR numba#8691 feedback.
gpuci run tests |
Now that #8691 is ready to go except for CI on that branch itself, I think this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only opened to try the code changes in #8620 with the original test matrix.