pkgconf: update to 1.9.5 and add patch to disable sorting #17692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Degawa <ccom@randomderp.com>
|
I guess there is no explanation as to why this fixes things? |
|
Not really. I guess because qsort is unstable is the only real explanation? Not sure why it doesn't break on Linux, unless they don't test pure static compilation? |
|
Could this PR merged. |
|
if you feel reasonably confident, sure. I was planning to write some pkgconf tests, but I can always do that later. |
|
This PR could wait if you feel like you can get tests written soon, but would of course prefer to be merged sooner than later. As far as I know, nothing that I know of requires 1.9.5 vs our current version, as it seems 1.9+ is mainly performance and dependency resolving. |
|
I'm busy over the weekend, so likely not too soon. Let's see :) |
lazka
added a commit
to lazka/MINGW-packages
that referenced
this pull request
Aug 4, 2023
This removes the patch added in msys2#17692 since the real issues is supposed to be fixed in this new release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work done by @MehdiChinoune, should fix #13390.
Tested by compiling FFmpeg and a bunch of other dependencies, and seems to work.