Skip to content

Conversation

ahanoff
Copy link

@ahanoff ahanoff commented Oct 13, 2022

Close #49

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: pulumi/setup-pulumi

"lockfileVersion" changed to 2, that's why so many changed lines in package-lock.json file

As a result, actions authors who move from targeting Node.js 12 to Node.js 16 should release with a new major version number to communicate that there is a possible breaking change for GitHub Enterprise Server 3.3 and earlier.

Github recommends to update major version upon runtime change, thus version changed to 2.0.0: https://github.blog/changelog/2022-05-20-actions-can-now-run-in-a-node-js-16-runtime/

@cengizhanhakan
Copy link

Hey @ahanoff are you also receiving a warning about the new @actions/core dependency?

@ahanoff
Copy link
Author

ahanoff commented Oct 19, 2022

Hey @ahanoff are you also receiving a warning about the new @actions/core dependency?

@cengizhanhakan no, actually 🤔 Could you send warning message for @actions/core package?

@BamWidyat
Copy link

@cengizhanhakan no, actually 🤔 Could you send warning message for @actions/core package?

The 'set-output' command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@ahanoff this is the message, and it can be solved by updating @actions/core package to version 1.10.0

@donfirst
Copy link

Can anyone who have the write access merge that pull request please ?

@cengizhanhakan
Copy link

@ahanoff @donfirst I don't think there is anyone that's why I skipped it. If you need it you can find a fork I created in my profile. or you can also go with @ahanoff's fork

@ahanoff
Copy link
Author

ahanoff commented Oct 26, 2022

The 'set-output' command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

@BamWidyat , I see. Well, this is different as it requires dependency update. This PR only updates github actions runtime, no changes to dependencies

@donfirst
Copy link

@ahanoff @donfirst I don't think there is anyone that's why I skipped it. If you need it you can find a fork I created in my profile. or you can also go with @ahanoff's fork

Thank you for your help - just switched. to your repo :-)

@ahanoff
Copy link
Author

ahanoff commented Nov 3, 2022

hi @mshick could you please take a look?

@hbiede
Copy link

hbiede commented Nov 4, 2022

I would also love if @actions/core could be tackled on this

@mshick
Copy link
Owner

mshick commented Nov 4, 2022

Yes, absolutely. Had no idea so many people were actually using this. My apologies, I'll get things sorted this weekend.

@mshick
Copy link
Owner

mshick commented Nov 4, 2022

@ahanoff This looks good, but I probably need to make some other updates as well. I'll get a PR up and ping you on it, and we can hopefully merge that one and close this one at the same time.

@mshick
Copy link
Owner

mshick commented Nov 4, 2022

I just publised v2 which handles all the deprecation notices and bumps to node 16. Thanks!

@mshick mshick closed this Nov 4, 2022
@ahanoff
Copy link
Author

ahanoff commented Nov 5, 2022

This looks good, but I probably need to make some other updates as well.

👎 motivates contribute next time

@mshick
Copy link
Owner

mshick commented Nov 5, 2022

@ahanoff My apologies, there were quite a few other changes that needed to be made before publishing a new version. It had been 2 years since I last looked at this! I welcome further contributions and appreciate you bringing the issue to my attention. Thanks again.

@mshick
Copy link
Owner

mshick commented Apr 24, 2023

@all-contributors please add @ahanoff for code

@allcontributors
Copy link
Contributor

@mshick

I've put up a pull request to add @ahanoff! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node12 is deprecated. Upgrade to node16
8 participants