-
Notifications
You must be signed in to change notification settings - Fork 60
feat: update action runtime to Node 16 #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @ahanoff are you also receiving a warning about the new @actions/core dependency? |
@cengizhanhakan no, actually 🤔 Could you send warning message for @actions/core package? |
@ahanoff this is the message, and it can be solved by updating |
Can anyone who have the write access merge that pull request please ? |
@BamWidyat , I see. Well, this is different as it requires dependency update. This PR only updates github actions runtime, no changes to dependencies |
hi @mshick could you please take a look? |
I would also love if |
Yes, absolutely. Had no idea so many people were actually using this. My apologies, I'll get things sorted this weekend. |
@ahanoff This looks good, but I probably need to make some other updates as well. I'll get a PR up and ping you on it, and we can hopefully merge that one and close this one at the same time. |
I just publised |
👎 motivates contribute next time |
@ahanoff My apologies, there were quite a few other changes that needed to be made before publishing a new version. It had been 2 years since I last looked at this! I welcome further contributions and appreciate you bringing the issue to my attention. Thanks again. |
@all-contributors please add @ahanoff for code |
I've put up a pull request to add @ahanoff! 🎉 |
Close #49
"lockfileVersion" changed to 2, that's why so many changed lines in package-lock.json file
Github recommends to update major version upon runtime change, thus version changed to 2.0.0: https://github.blog/changelog/2022-05-20-actions-can-now-run-in-a-node-js-16-runtime/