Skip to content

feat: added support for create server API and updated Server data model. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 16, 2024
Merged

feat: added support for create server API and updated Server data model. #66

merged 4 commits into from
Dec 16, 2024

Conversation

sanchitrk
Copy link

Added support for create server API as per docs and updated server data model struct.

@mergify Mergify
Copy link

mergify bot commented Dec 14, 2024

Welcome to our open-source project! 💘

@mrz1836 mrz1836 added feature Any new significant addition update General updates labels Dec 15, 2024
@mrz1836 mrz1836 self-requested a review December 15, 2024 14:48
@mrz1836
Copy link
Owner

mrz1836 commented Dec 15, 2024

@sanchitrk thanks for the contribution. Please review the linting and tests above, some are not passing.

@sanchitrk
Copy link
Author

@mrz1836 thanks for reviewing. Yes there was some issues with linting and example file. I fixed the linting by locally running the make command and removed the example file.

@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 91.31%. Comparing base (5bedea8) to head (9ccb6da).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
servers.go 0.00% 30 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   95.77%   91.31%   -4.46%     
==========================================
  Files          13       13              
  Lines         615      645      +30     
==========================================
  Hits          589      589              
- Misses         18       48      +30     
  Partials        8        8
Flag Coverage Δ
unittests 91.31% <0.00%> (-4.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
servers.go 34.78% <0.00%> (-65.22%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bedea8...9ccb6da. Read the comment docs.

mrz1836
mrz1836 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Owner

@mrz1836 mrz1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrz1836 mrz1836 merged commit ad34971 into mrz1836:master Dec 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrz1836 mrz1836 mrz1836 approved these changes

Assignees

@mrz1836 mrz1836

Labels
feature Any new significant addition update General updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanchitrk @mrz1836