Set Request.GetBody in doRequest
#58
Conversation
|
Welcome to our open-source project! 💘 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #58 +/- ##
==========================================
- Coverage 97.10% 96.75% -0.36%
==========================================
Files 13 13
Lines 552 554 +2
==========================================
Hits 536 536
- Misses 9 10 +1
- Partials 7 8 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
|
@mrz1836 just wondering what your release process is like? I see the last release |
|
@vincent-stytch usually same day on the release :P |
I was running into an issue periodically:
when trying to send an email through this library.
Based on research (golang/go#62453, https://github.com/stripe/stripe-go/pull/711/files, https://ragoragino.dev/blog/softwareengineering/2022-02-05-goaway-test/index.html) it looks like Golang attempts a retry when receiving
GOAWAYfrom a server. [https://sourcegraph.com/github.com/golang/net/-/commit/cffdcf672aee934982473246bc7e9a8ba446aa9b?visible=2](Go code here)But, this means that we need to define a
GetBodyfunction in the request to allow the http2 package to retry. Since the payload we have here is static, we can set it equal to theBody.I tested this by patching my dependency with this new version, and my emails still send, so I think this at least won't break anything.