Skip to content

fix directory matching with trailing slashes #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix directory matching with trailing slashes #335

wants to merge 2 commits into from

Conversation

Trott
Copy link
Contributor

@Trott Trott commented Dec 12, 2021

What is the purpose of this pull request?

Addresses #290.

What changes did you make? (Give an overview)

I added the tests in #291, reverted the refactoring commit that caused the issue, sorted out merge conflicts during the revert, and modified the tests as appropriate. There are a small number of test cases in the smoke tests from #291 that still do not pass, but I think this is still worth landing and releasing. (FWIW, this issue is keeping me from updating to fast-glob@3 on at least one project.)

This was referenced Dec 12, 2021
Closed
Merged
@mrmlnc mrmlnc self-assigned this Dec 15, 2021
@Trott
Copy link
Contributor Author

Trott commented Dec 18, 2021

The linter was complaining about a missing plugin for me when I tried to run it locally. Guess it works fine on CI and I should look into what was going on there.... Anyway, I'll get these lint errors fixed...

@Trott
Copy link
Contributor Author

Trott commented Dec 18, 2021

The linter was complaining about a missing plugin for me when I tried to run it locally. Guess it works fine on CI and I should look into what was going on there.... Anyway, I'll get these lint errors fixed...

FWIW, npm install doesn't result in a working linter on GitPod, but it works fine locally. Using yarn instead on GitPod works. I don't know why that is. Probably some global npm config file somewhere.

@mrmlnc mrmlnc added this to the 3.2.8 milestone Jan 1, 2022
@mrmlnc mrmlnc mentioned this pull request Jan 1, 2022
Merged
@mrmlnc
Copy link
Owner

mrmlnc commented Jan 1, 2022

@Trott, thanks for investigating the problem and the detailed description. I made changes in #339 based on your changes with minor remarks to satisfy all tests from #291.

@mrmlnc mrmlnc closed this Jan 1, 2022
@Trott Trott deleted the fix-trailing-slash branch January 1, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mrmlnc mrmlnc

Labels
None yet
Projects
None yet
Milestone
3.2.8
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @mrmlnc @rijnhard