build: preserve version when build via go install #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves version handling by implementing a fallback mechanism to use embedded version information when the application is built via go install, ensuring proper version reporting in both production and development builds.
- Extracted version variables from
main.goto dedicatedversion.gofile - Added dependency on
versioninfo/v2package for automatic version detection - Updated GoReleaser configuration to use
-trimpathflag and additional build metadata
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| version.go | New file containing version variables and Version() function with fallback logic |
| options.go | Updated version flag handler to use the new Version() function |
| main.go | Removed version variables (moved to version.go) |
| go.mod | Added versioninfo/v2 dependency |
| .goreleaser.yml | Enhanced build configuration with trimpath and additional ldflags |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.