Skip to content

WebGPURenderer - Disable Draw Call when object.count = 0 #30881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2025
Merged

WebGPURenderer - Disable Draw Call when object.count = 0 #30881

merged 3 commits into from
Apr 7, 2025

Conversation

cmhhelgeson
Copy link
Contributor

@cmhhelgeson cmhhelgeson commented Apr 7, 2025 •
edited by Mugen87
Loading

Fixed #30882.

Description

Modifies the instanceCount behavior to acknowledge when the user sets object.count to 0.

@cmhhelgeson cmhhelgeson changed the title WebGPURenderer - Disable Renderer when object.count = 0 WebGPURenderer - Disable Draw Call when object.count = 0 Apr 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 7, 2025 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.49
78.38		 336.49
78.38		 +0 B
+0 B
WebGPU 542.05
150.14		 542.09
150.14		 +35 B
+3 B
WebGPU Nodes 541.52
150.03		 541.55
150.04		 +35 B
+2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.42
112.22		 465.42
112.22		 +0 B
+0 B
WebGPU 614.9
166.18		 614.93
166.19		 +35 B
+3 B
WebGPU Nodes 569.88
155.59		 569.92
155.59		 +35 B
+6 B

@cmhhelgeson cmhhelgeson marked this pull request as draft April 7, 2025 01:20
@cmhhelgeson cmhhelgeson marked this pull request as ready for review April 7, 2025 01:31
Mugen87
Mugen87 reviewed Apr 7, 2025
View reviewed changes
@Mugen87 Mugen87 added this to the r176 milestone Apr 7, 2025
@Mugen87 Mugen87 merged commit d0d0e1d into mrdoob:dev Apr 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r176
Development

Successfully merging this pull request may close these issues.

THREE.Sprite() still renders when object.count = 0
2 participants
@cmhhelgeson @Mugen87