Docs: Improve types #30879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Mugen87 merged 1 commit into mrdoob:dev from s-rigaud:improve-jsdoc-types

Apr 7, 2025

Contributor

s-rigaud commented Apr 6, 2025

Description

Fix some types and add context for some variable values.


          Docs: improve types

88ca87b

github-actions bot commented Apr 6, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

	Before	After	Diff
WebGL	336.49 78.38	336.49 78.38	+0 B +0 B
WebGPU	542.03 150.13	542.03 150.13	+0 B +0 B
WebGPU Nodes	541.5 150.03	541.5 150.03	+0 B +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

	Before	After	Diff
WebGL	465.42 112.22	465.42 112.22	+0 B +0 B
WebGPU	614.87 166.18	614.87 166.18	+0 B +0 B
WebGPU Nodes	569.86 155.58	569.86 155.58	+0 B +0 B

Mugen87 approved these changes

View reviewed changes

Mugen87 added this to the r176 milestone

Mugen87 merged commit dd26821 into mrdoob:dev

12 checks passed

s-rigaud deleted the improve-jsdoc-types branch

April 15, 2025 02:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet