TSL: Fix instance() optional parameter
#30848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the instance() function by making the instanceColor parameter optional, while updating both the documentation and the parameter count settings accordingly.
- Constructor now sets a default value (null) for the instanceColor parameter.
- Documentation annotations have been updated to indicate its optional status.
- The parameter length configuration has been revised using setParameterLength.
Comments suppressed due to low confidence (1)
src/nodes/accessors/InstanceNode.js:224
- Ensure that setParameterLength(2, 3) accurately reflects the intended parameter requirements after making instanceColor optional, and that this change preserves backwards compatibility.
export const instance = /*@__PURE__*/ nodeProxy( InstanceNode ).setParameterLength( 2, 3 );
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
/cc @brunosimon |
This was referenced Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30783
Description
Fix
instance()optional parameter.