Skip to content

Conversation

Shane-oo
Copy link
Contributor

@Shane-oo Shane-oo commented Feb 20, 2025

Fixed #30568.

Description

Render the Reflector if forceUpdate is set to true.

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 24, 2025

Do you mind adding the same change in the node version? You can add the forceUpdate flag to ReflectorBaseNode and evaluate it in updateBefore(), see:

if ( _view.dot( _normal ) > 0 ) return;

@Shane-oo
Copy link
Contributor Author

Do you mind adding the same change in the node version? You can add the forceUpdate flag to ReflectorBaseNode and evaluate it in updateBefore(), see:

if ( _view.dot( _normal ) > 0 ) return;

Sure thing, should be done

Copy link

github-actions bot commented Feb 24, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.64
78.39
336.64
78.39
+0 B
+0 B
WebGPU 522.53
145.06
522.6
145.08
+68 B
+20 B
WebGPU Nodes 522
144.96
522.07
144.98
+68 B
+21 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.69
112.26
465.69
112.26
+0 B
+0 B
WebGPU 593
160.69
593
160.69
+0 B
+0 B
WebGPU Nodes 548.13
150.12
548.13
150.12
+0 B
+0 B

@Mugen87 Mugen87 added this to the r174 milestone Feb 25, 2025
@Mugen87 Mugen87 changed the title Add needsUpdate to Reflector Reflector: Add forceUpdate. Feb 25, 2025
@Mugen87 Mugen87 merged commit a8a6faf into mrdoob:dev Feb 25, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflector add needsUpdate flag
2 participants