Timer: Add connect()/disconnect().
#30551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be connected to the |
|
Maybe something like: renderer.setTimer( timer );In this way, the renderer could call |
|
I think one timer should come as default in the Renderer, so it can use renderer.getTimer() in the examples if you prefer. Synchronization will help to pause the game for example and preserve the shader's momentum, currently this is only possible if the user creates an isolated timer uniform |
This was referenced Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30522 (comment)
Description
The PR implements
connect()/disconnect()to make the ctor side-effect free.This change must be noted in the migration guide since calling
timer.connect( document );is now mandatory if the Page Visibility API should be used to avoid large time delta values.